search

hexojs / hexo-html-minifier

Minify HTML files with HTMLMinifier.
MIT License
26 stars 16 forks source link

chore: require at least node 8 #22

Closed curbengh closed 5 years ago

curbengh commented 5 years ago

chore: replace gulp+istanbul with nyc

chore: specify files to publish

refactor: replace minimatch with micromatch

feat: aggressive defaults

Closes #20, Closes #21

tomap commented 5 years ago

By looking at the Travis logs, there seem to be an issue with coveralls, which might explain why no coverall is done for this or Appart from that, LGTM

curbengh commented 5 years ago

currently there is no unit test, so no output for coveralls.

segayuu commented 5 years ago

Unfortunately, this PR is too big.

Divided into the above three, you can reduce the burden of reviewers and the complexity of PR. Also, the minimatch to micromatch replacement is not refactoring. Both have almost the same behavior, but the behavior for backslash is different. I think that each PR content is very good! It's all related, so I'm very glad if you put it together as a single issue.