hexojs / hexo-renderer-less

Less renderer for Hexo.

https://hexo.io/

MIT License

14 stars 10 forks source link

feat: path globbing #37

Closed curbengh closed 3 years ago

curbengh commented 4 years ago

Related to #14

globbing only applies to hexo-processed files; e.g. doesn't apply to node_modules/ folder.

coveralls commented 4 years ago

Coverage remained the same at 100.0% when pulling 1ddc395a22a89dcc68842a2f07e15187214e2090 on curbengh:globbing into 25166f350780d7edfec1a2d7f1ac64078aba80f7 on hexojs:master.

SukkaW commented 4 years ago

@curbengh micromatch has a is-glob: https://github.com/micromatch/is-glob/

Could it be used to avoid Breaking Changes?

curbengh commented 4 years ago

micromatch has a is-glob: https://github.com/micromatch/is-glob/

Could it be used to avoid Breaking Changes?

incorporated isGlob, breaking change averted.

curbengh commented 4 years ago

14 may require (not sure) globbing outside of hexo-processed files, like node_modules/ folder, as it mentions node-glob.

I'm not so keen on node-glob because I prefer not to use the dated minimatch. micromatch has a replacement called glob-fs, but it's not a drop-in as it doesn't support windows.

SukkaW commented 4 years ago

Any ideas about non-glob support? For example, add suffix ** or /** when processing the config.

curbengh commented 4 years ago

Since micromatch is included, can implement exclude: option too (in a separate PR).

curbengh commented 3 years ago

Rebased