search

hexojs / hexo-renderer-pandoc

A pandoc-markdown-flavor renderer for hexo.
https://npmjs.com/hexo-renderer-pandoc
MIT License
114 stars 32 forks source link

add back extension capability #27

Closed Ritsuka314 closed 5 years ago

Ritsuka314 commented 5 years ago

Hi @wzpan @alexpnt ,

The commit https://github.com/wzpan/hexo-renderer-pandoc/commit/1747d9f3479eebd398568d623df6deae8615882d#diff-168726dbe96b3ce427e7fedce31bb0bc disabled the smart extension by default, which I understand.

But why remove the user specified extensions capability introduced in the previous commit https://github.com/wzpan/hexo-renderer-pandoc/commit/c0ec725baed03f225769fff9f957fd968aaf05a5#diff-168726dbe96b3ce427e7fedce31bb0bc ?

Further, if user specified extensions are intended to be removed indeed, then why line 8-13 in the above stated commit have not been removed too?

This pull request restores that capability.

wzpan commented 5 years ago

It should be well to add it back. I merged. Thanks!

Ritsuka314 commented 5 years ago

Many thanks for accepting my pull request. I have switched to your tool from markdown-it for two years and the experience has been really good. Thanks!

wzpan commented 5 years ago

@RichardYan314 Thanks for using it.

In fact even I don't use hexo-renderer-pandoc now because I want to write my blog on my Android Pad and there is no way to install pandoc on it.

From your experience I think you can be a good collaborator for this project. So I've sent you an invitation. It's up to you to decide whether to join this project and become a maintainer. Cheers~ 🍷

Ritsuka314 commented 5 years ago

@wzpan I'd very honoured and appreciate! Cheers~