search

hexojs / hexo-util

Utilities for Hexo.
MIT License
93 stars 59 forks source link

test: improve coverage #319

Closed D-Sketon closed 1 year ago

D-Sketon commented 1 year ago

https://github.com/hexojs/hexo/issues/3984

coveralls commented 1 year ago

Coverage Status

coverage: 97.274% (+1.9%) from 95.402% when pulling ad1d0db118089aaa1a16e569f7004c7cc122ae9f on D-Sketon:master into 3b0bc15bacc36c3f0d6790789ef4f7aca51b0ad7 on hexojs:master.

D-Sketon commented 1 year ago

TypeScript 5.1 now ships JavaScript functionality that was introduced in ECMAScript 2020. As a result, at minimum TypeScript must be run in a reasonably modern runtime. For most users, this means TypeScript now only runs on Node.js 14.17 and later.

should we remove Tester using Node 12.x ?

SukkaW commented 1 year ago

TypeScript 5.1 now ships JavaScript functionality that was introduced in ECMAScript 2020. As a result, at minimum TypeScript must be run in a reasonably modern runtime. For most users, this means TypeScript now only runs on Node.js 14.17 and later.

should we remove Tester using Node 12.x ?

Sure! And hexo-util@3 has dropped Node.js 12 already, for some reason we forgot to remove the Node.js 12 test runner.

SukkaW commented 1 year ago

@D-Sketon

https://github.com/hexojs/hexo-util/pull/321 has been merged. Would you like to rebase your this PR?

D-Sketon commented 1 year ago

@D-Sketon

321 has been merged. Would you like to rebase your this PR?

ok

stevenjoezhang commented 1 year ago

Superseded by https://github.com/hexojs/hexo-util/pull/354