search

hexojs / hexo

A fast, simple & powerful blog framework, powered by Node.js.
https://hexo.io
MIT License
39.46k stars 4.85k forks source link

closed tag problem of generated HTML #3652

Closed JoeyBling closed 5 years ago

JoeyBling commented 5 years ago

When I execute hexo s-g or hexo g The generated HTML tag does not end properly,But it doesn't affect browser rendering The version I used 3.9.0 But I didn't have this problem with version 3.7.1 I use the theme yilia-plus I've tried this with the official default theme,But problems remain How can i debug or fix it ?

curbengh commented 5 years ago

I noticed this issue before, though I couldn't reproduce it reliably

Can you attach your package.json and _config.yml (let me know if they're private)? It may be caused by plugins.

JoeyBling commented 5 years ago

@curbengh Thank you for your reply I use the official default theme landscape，the problem can also occur! The other configurations were left untouched. version 3.9.0

JoeyBling commented 5 years ago

@curbengh At the beginning I also thought the theme plug-in problem, later I directly use the 'hexo init' command to initialize a new project will also appear this problem

curbengh commented 5 years ago

I can reproduce the issue, but not in local testing after modify something. Annoyingly, I can't remember the changes I made.

I'll do more testing.

JoeyBling commented 5 years ago

@curbengh I've debugging, and find there's something wrong with this pull request

https://github.com/hexojs/hexo/pull/3315

When I delete that file, the problem won't appear

But I don't know if there will be any other problems later, so I would like to ask for your help. Thank you

curbengh commented 5 years ago

Somehow in my cause the issue goes away even with "meta_generator.js". Can you try this modified landscape theme?

JoeyBling commented 5 years ago

@curbengh I don't think it's about the subject. I'll try first

JoeyBling commented 5 years ago

@curbengh Sorry, I take back what I said just now, this modified theme is actually ok， But the question is what? I don't know

JoeyBling commented 5 years ago

I use the theme yilia-plus

yoshinorin commented 5 years ago

@JoeyBling @curbengh My understanding is that this issue has already been solved https://github.com/hexojs/hexo-theme-landscape/pull/123

JoeyBling commented 5 years ago

@YoshinoriN Thank you very much. You solved my problem perfectly. I fixed my theme according to this bug

And I have another question, how to remove the meta tag generator property generated

<meta name="generator" content="Hexo 3.9.0">

JoeyBling commented 5 years ago

fix it

https://github.com/hexojs/hexo-theme-landscape/pull/123

curbengh commented 5 years ago

And I have another question, how to remove the meta tag generator property generated

currently, there is no option to disable it. I could add the option.

JoeyBling commented 5 years ago

@curbengh I think your can add this and look forward to fix it in the next release