Closed uiolee closed 8 months ago
It's time to release a new version of hexo-front-matter
Ready for release hexo-front-matter v4.2.0.
still exists another types
issue. It leads hexo build fail. (see above)
I think it need time to investigate and update.
we could postpone this issue and release v7 first.
still exists another
types
issue. It leads hexo build failI think it need time to investigate.
we could postpone this issue and release v7 first.
maybe we can fix it in https://github.com/hexojs/hexo/pull/5271 ?
still exists another
types
issue. It leads hexo build fail. (see above)I think it need time to investigate.
we could postpone this issue and release v7 first.
https://github.com/hexojs/hexo-fs/blob/72f16b383bce2a438aed3076e47be352f9e41d1c/lib/fs.ts#L236-L237
The file encoding defaults to utf-8, so the type is basically string
~It seems that hexo-fs will only return string, maybe hexo-fs should be modified.~
https://nodejs.org/docs/latest-v18.x/api/fs.html#fspromisesreadfilepath-options
~https://github.com/hexojs/hexo-fs/blob/72f16b383bce2a438aed3076e47be352f9e41d1c/lib/fs.ts#L235-L246~
The file encoding defaults to utf-8, so the type is basically string
yes
Besides, I found that fs.readFile(target, null)
will cause
TypeError: Cannot convert undefined or null to object
However, The signature of the writeFile function is
function readFile(path: string, options?: ReadFileOptions | null): BlueBirdPromise<string | Buffer>
null is allowed to be passed in is this a bug?
still exists another
types
issue. It leads hexo build fail. (see above)I think it need time to investigate and update.
we could postpone this issue and release v7 first.
fix in #5271
fix in #5271
thanks! test passed.
~Originally posted by @Pcrab in https://github.com/hexojs/hexo/issues/5202#issuecomment-1544052137~
in #5202, we lock hexo-front-matter version to 4.0.0
https://github.com/hexojs/hexo/blob/2a2cc9a89f3f291d2ba93e3a4d7eeb3b8ba98bbe/package.json#L47
hexo build failed
after hexojs/hexo-front-matter#67, hexo still have another types issue, which leads build failed.