Closed yoshinorin closed 8 months ago
Publish flamegraph to https://98a38e86ecc0f039a07dece2e29f0dcaaffc98fa-16-hexo.surge.sh/flamegraph.html
Totals | |
---|---|
Change from base Build 6707257857: | 0.0% |
Covered Lines: | 8997 |
Relevant Lines: | 9039 |
what circumstances does this problem occur. I can't reproduce it.
@uiolee
what circumstances does this problem occur. I can't reproduce it.
Checkout master
branch and just run npm run build
.
// My local env
$ systeminfo
OS Name: Microsoft Windows 11 Pro
OS Version: 10.0.22621 N/A Build 22621
$ node -v
v20.5.1
$ tsc -v
Version 4.6.4
// chekout master branch
$ git checkout master
Switched to branch 'master'
Your branch is up to date with 'upstream/master'.
$ git branch -v --contains
* master f7a581ea release: v7.0.0 (#5329)
// just run build command
$ npm run build
> hexo@7.0.0 build
> tsc -b
lib/hexo/multi_config_path.ts:65:28 - error TS2345: Argument of type 'number' is not assignable to parameter of type 'string'.
65 log.i('Config based on', count, 'files');
``
I try node@20.5.1 and still can't reproduce. But found more issue on tsc@4.6.4
```bash $ npx tsc -v Version 4.6.4 $ npm run build > hexo@7.0.0 build > tsc -b lib/box/index.ts:60:3 - error TS4055: Return type of public method from exported class has or is using private name '_File'. 60 _createFileClass() { ~~~~~~~~~~~~~~~~ lib/hexo/index.ts:463:3 - error TS4055: Return type of public method from exported class has or is using private name 'Locals'. 463 _generateLocals() { ~~~~~~~~~~~~~~~ lib/hexo/router.ts:17:27 - error TS4020: 'extends' clause of exported class 'RouteStream' has or is using private name 'Readable'. 17 class RouteStream extends Readable { ~~~~~~~~ Found 3 errors. ```
v4.6.4 found 3 errors v4.9.5 found 0 error
v4.6.4 found 3 errors v4.9.5 found 0 error
Can we specify which version of tsc
to use in package.json
or other files?
I think we can follow the latest version
What does it do?
fix
TS2345: Argument of type 'number' is not assignable to parameter of type 'string'.
error. I ignore them with@ts-ignore
when I publishedv7.0.0
.Screenshots
N/A
Pull request tasks