search

hexojs / hexo

A fast, simple & powerful blog framework, powered by Node.js.
https://hexo.io
MIT License
38.83k stars 4.75k forks source link

revert(categories,tags): revert behavior of locals.tags and locals.categories #5388

Closed uiolee closed 2 months ago

uiolee commented 6 months ago

https://github.com/hexojs/hexo/issues/5380#issuecomment-1871282281

What does it do?

revert some changes of #5119

fix #5380 fix #5367

Screenshots

Pull request tasks

github-actions[bot] commented 6 months ago

How to test

git clone -b fix_categories_tags https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test
D-Sketon commented 2 months ago

any update?

uiolee commented 2 months ago

IDK

stevenjoezhang commented 2 months ago

I remember https://github.com/hexojs/hexo/pull/3624 was to solve a problem https://github.com/theme-next/hexo-theme-next/pull/42, and the https://github.com/hexojs/hexo/pull/5119 was to speed up rendering. The problem wasn't completely solved, and we will need to consider better solutions in the future. Additionally, we need to advise theme developers not to use private properties of the warehouse objects.