chore: make callback on exit optional

hexojs / hexo

A fast, simple & powerful blog framework, powered by Node.js.

https://hexo.io

MIT License

38.82k stars 4.75k forks source link

chore: make callback on exit optional #5421

Closed dimaslanjaka closed 4 months ago

dimaslanjaka commented 4 months ago

What does it do?

based on https://hexo.io/api/index.html#Exit method hexo.exit() is not always has callback function, make it optional for better typing with typescript

Screenshots

Pull request tasks

[ ] Add test cases for the changes.
[x] Passed the CI test.

github-actions[bot] commented 4 months ago

How to test

git clone -b hexo-exit-fix https://github.com/dimaslanjaka/hexo.git
cd hexo
npm install
npm test

github-actions[bot] commented 4 months ago

flamegraph

https://92f414c5991c9168024a14c9246645b721b4a6f2-14-hexo.surge.sh/flamegraph.html https://92f414c5991c9168024a14c9246645b721b4a6f2-16-hexo.surge.sh/flamegraph.html https://92f414c5991c9168024a14c9246645b721b4a6f2-18-hexo.surge.sh/flamegraph.html

dimaslanjaka commented 4 months ago

@SukkaW review pls