search

hexonaut / bitcoin-transaction

Send Bitcoins from one wallet to another. This is designed to be as simple to use as possible.
MIT License
49 stars 34 forks source link

Number of confirmations is fixed #8

Closed osagga closed 6 years ago

osagga commented 6 years ago

https://github.com/Blank101/bitcoin-transaction/blob/a60bc3f201601d0d80b9e2af68ba189db4e2b077/index.js#L190

The number of confirmations should be controllable, at least for testnet.

hexonaut commented 6 years ago

Yes this is a good point. I can make this change when I get a moment (or feel free to submit a PR, and I'll merge it in right away). :)

kidsil commented 6 years ago

just noticed @osagga 's PR after adding my own: https://github.com/Blank101/bitcoin-transaction/pull/10 Mine doesn't have the indentation fixes so it's more concentrated on the feature :)

hexonaut commented 6 years ago

@kidsil Merged yours in.