Graphics and Text - Githubissues

hexonaut / haxe-phaser

Haxe externs for Phaser.

MIT License

51 stars 9 forks source link

Graphics and Text #35

Closed adireddy closed 10 years ago

adireddy commented 10 years ago

Adding missing methods in pixi.primitives.Graphics
Extending phaser.gameobjects.Graphics with pixi.primitives.Graphics
Added missing destroy method to pixi.text.Text

hexonaut commented 10 years ago

Looks good. Thanks!

One small point, in the future could you try and stick as closely as possible to the format that is exported by the js2hx tool to avoid future merge conflicts. For example you are writing "public" on all class members/methods which is implied for extern classes. Also removing the line break before the final closing curly brace. I know this seems nit-picky, but it will save me some head-ache when merging future Phaser updates.

adireddy commented 10 years ago

Sure.