hexonaut / haxe-phaser

Haxe externs for Phaser.
MIT License
51 stars 9 forks source link

methods missing in components.Core, pixi.DisplayObjectContainer #55

Closed Yann-P closed 9 years ago

Yann-P commented 9 years ago

I've been using this phaser definition for a month and it's VERY handy. Autocompletion and compile-time errors have saved me so much time compared to pure js phaser development.

However I found some issues with sprites, they are missing some methods like update, postUpdate (from gameobjects.components.Core) and several methods from PIXI (like removeChild from pixi.DisplayObjectContainer).

That surprised me because there is no reason for js2hx to ignore this method compared to getLocalBounds (from pixi.DisplayObjectContainer) that is in the externs and is declared with the exact same syntax in the .js source file.

I also found other issues :

note the String type for width and height

I am interested in fixing the externs manually if you want (that's what I've been doing locally on my computer for now, I could become a contributor to this repo) but maybe it would be better to find the issue with js2hx. I'll take a look.

hexonaut commented 9 years ago

Hey, thanks for your interest in the project. js2hx is far from perfect. Instead I used it as a jumping off point.

I would recommend making manual changes, but feel free to get things fixed in js2hx as well for future major updates. I'll add you as a contributor so you can get started making fixes.