search

hexops / vecty

Vecty lets you build responsive and dynamic web frontends in Go using WebAssembly, competing with modern web frameworks like React & VueJS.
BSD 3-Clause "New" or "Revised" License
2.8k stars 143 forks source link

Introduce Go Modules #214

Closed marwan-at-work closed 5 years ago

slimsag commented 6 years ago

Looks like this is causing some failure on CI

marwan-at-work commented 6 years ago

@slimsag not sure what megacheck does but this is what's being returned: 

1.68s$ megacheck -tags=js ./...
/home/travis/.gimme/versions/go1.11.linux.amd64/src/runtime/internal/sys/zgoos_linux.go:8:7: GOOS redeclared in this block
couldn't load packages due to errors: runtime, runtime/internal/sys

Sounds like a possible error in ignoring build tags. Does it make any sense to you?

slimsag commented 6 years ago

megacheck is a very nice linter 😃

My guess is that megacheck is not playing well with go modules right now. It looks like there is an open issue and a separate next branch there for adding go modules support https://github.com/dominikh/go-tools/issues/328

Probably we can try just checking out that next branch and seeing if that fixes the problem, otherwise we will have to temporarily disable megacheck which would be sad :/

AnikHasibul commented 5 years ago

Take a look at #220

slimsag commented 5 years ago

Moved the blackfriday upgrade to https://github.com/gopherjs/vecty/pull/228 since PRs should be scoped to one singular change.

slimsag commented 5 years ago

Fixed conflicts + remaining issues and opened new PR https://github.com/gopherjs/vecty/pull/229

(I retained your authorship information so you still get credit, of course 😄)