document func event.Timeout

[ilmanzo]

fix #226

[codecov-io]

Codecov Report

Merging #233 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   57.64%   57.64%           
=======================================
  Files           3        3           
  Lines         654      654           
=======================================
  Hits          377      377           
  Misses        219      219           
  Partials       58       58

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d00da0c...498bd58. Read the comment docs.

[pdf]

This file is generated, so I think this would need to be overridden somehow in the generator (or source doc).

[ilmanzo]

I see... But running the generator, I get a file without any func definition. Maybe reference page has changed, or parsing is broken ?

//go:generate go run generate.go

// Package event defines markup to bind DOM events.
//
// Generated from "Event reference" by Mozilla Contributors,
// https://developer.mozilla.org/en-US/docs/Web/Events, licensed under
// CC-BY-SA 2.5.
package event

import "github.com/gopherjs/vecty"

[slimsag]

Yeah, the generator is broken at this point due to MDN changes, that doesn't surprise me. See https://github.com/gopherjs/vecty/issues/136

I think making this a hand-written file for now, until we have a better generator source (i.e. https://github.com/gopherjs/vecty/issues/136) is fine. That way we can continue to improve the package and once we do have a better generator, we can use the existing packages as test cases effectively.

[slimsag]

@ilmanzo I'd like to merge this as-is, not sure why you closed the PR? Would you be willing to re-send it?

[ilmanzo]

Sorry, I understood you were fixing the generator... NP I'll reopen it