E164.parse gives preference to discontinued number blocks

[tokengeek]

When using E164.parse with "+" formatted numbers the country_code for 21 countries is incorrect.

These relate to three digit codes that the the first two digits match a discontinued code.

For example for a number in the Czech Republic (420):

E164.parse("+420298888888") # => ["42", "02", "98888888"]

"42" is 'previously assigned to [Czechoslovakia] until its breakup. Czech Republic and Slovakia used this common code until 1 March 1997.'

I've added test cases to be added in to spec/e164_spec.rb

  describe "#parse" do
    it 'should not give preference to discontinued number blocks' do
      E164.parse("+420298888888")[0].should == "420"
    end

    CountryCodes.each do |code, data|
      it "should pick up the correct country code for #{data[:description]} when in + format" do
        # Create a false number in + format because the code provided is correct
        fake_number = "+#{code}1234567"
        E164.parse(fake_number)[0].should == code
      end
    end
  end

Running this against 69f6236 gives 22 failures. 1 for the special Czech Republic case and 21 for all the cases where the parsing seems to pick up on a shorter code first.

List of affected Countries:

• Ukraine (380 seen as 38)
• Serbia (381 seen as 38)
• Montenegro (382 seen as 38)
• Croatia (385 seen as 38)
• Slovenia (386 seen as 38)
• Bosnia and Herzegovina (387 seen as 38)
• shared code for groups of nations (388 seen as 38)
• Republic of Macedonia (389 seen as 38)
• Czech Republic (420 seen as 42)
• Slovakia (421 seen as 42)
• Liechtenstein (423 seen as 42)
• Lithuania (370 seen as 37)
• Latvia (371 seen as 37)
• Estonia (372 seen as 37)
• Moldova (373 seen as 37)
• Armenia (374 seen as 37)
• Belarus (375 seen as 37)
• Andorra (376 seen as 37)
• Monaco (377 seen as 37)
• discontinued (was assigned to [San Marino], see [+378]) (378 seen as 37)
• Vatican City (379 seen as 37)

[hexorx]

So it looks like the codes 37, 38 and 42 should be removed when it is finding the country code. Does that sound right?

[tokengeek]

I think that's right. I think it's unlikely you would want to retain the old data in order to match numbers which are no longer in use.

[hexorx]

Thank you @scsmith for the fix.