search

hexparrot / mineos-node

node.js implementation of mineos minecraft management
GNU General Public License v3.0
334 stars 170 forks source link

Install script attempts to retrieve incorrect JDK #263

Closed burtonis closed 6 years ago

burtonis commented 7 years ago

Following the instructions at [https://minecraft.codeemo.com/mineoswiki/index.php?title=MineOS-node_(apt-get)], Debian 8.8 (x64):

The wget-friendly linked install script attempts to get openjdk-7-jre-headless instead of openjdk-8-jre-headless

Nodejs also reports "na" as the version, but this doesn't appear to affect the install.

hexparrot commented 7 years ago

This is actually a much harder problem to address. For one, Ubuntu 14 is still a thing. It shouldn't be, seeing as how 16.04 is pretty much more recommended across the board, but 14.04 installations with MineOS installed atop it, still exist.

And because of this, changing the openjdk-7 to openjdk-8 isn't necessarily a simple change.

For Debian though, 8 is an easy change. So this requires somehow that the script prefer one over the other, or I have to change the documentation so that both are maintained with their own gist.

After all, 8 should be used everywhere, but then again, in order to install 8 for Trusty, Xenial, and Debian releases, it'd require Jessie-Backports to be added or maybe not...or different permutations.

I'll ponder on this.

burtonis commented 6 years ago

Thanks- I didn't realise it was such a complex task!

Is there some way to programmatically select the latest version, or determine the "default" openjdk-jre package version?

On Tue, 12 Sep. 2017, 02:18 William Dizon notifications@github.com wrote:

This is actually a much harder problem to address. For one, Ubuntu 14 is still a thing. It shouldn't be, seeing as how 16.04 is pretty much more recommended across the board, but 14.04 installations with MineOS installed atop it, still exist.

And because of this, changing the openjdk-7 to openjdk-8 isn't necessarily a simple change.

For Debian though, 8 is an easy change. So this requires somehow that the script prefer one over the other, or I have to change the documentation so that both are maintained with their own gist.

After all, 8 should be used everywhere, but then again, in order to install 8 for Trusty, Xenial, and Debian releases, it'd require Jessie-Backports to be added or maybe not...or different permutations.

I'll ponder on this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hexparrot/mineos-node/issues/263#issuecomment-328580971, or mute the thread https://github.com/notifications/unsubscribe-auth/AGC2QvMJcLTgK8FHH1EOKC5iZm2uedRgks5shV1WgaJpZM4PTOfa .

hexparrot commented 6 years ago

I'm probably gonna start rewriting the scripts now, on the assumption that Ubuntu 14 is past its prime.

burtonis commented 6 years ago

Thanks for the update. Not sure if there's a way I can help, but if I can please let me know.

On 15 May 2018 at 06:26, William Dizon notifications@github.com wrote:

I'm probably gonna start rewriting the scripts now, on the assumption that Ubuntu 14 is past its prime.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hexparrot/mineos-node/issues/263#issuecomment-388951236, or mute the thread https://github.com/notifications/unsubscribe-auth/AGC2QlsGFVsMWoQqThKKpnilYrcbKLVAks5tyehsgaJpZM4PTOfa .

-- Regards, Ian Burton ian.burton@gmail.com

hexparrot commented 6 years ago

You were absolutely on the right track with a metapackage for the default version: default-jre-headless

I've actually just updated all the wiki to make Ubuntu 14 less a focus altogether, but having default-jre-headless also means I can write it out of the convenience scripts, too!

Thanks for the reporting of this issue; I'm much happier with the install scripts now!