hexplor / grav-plugin-latest-tweets

Display latest tweets from your twitter account on your grav page.
MIT License
6 stars 0 forks source link

Hardcoded timezone set to 'Europe/London' #7

Open dabonde opened 4 years ago

dabonde commented 4 years ago

Investigated an issue in our grav site where scheduled publishing and unpublishing of content wasnt working. Discovered that this plugin was setting the timezone to London, shown below.

https://github.com/hexplor/grav-plugin-latest-tweets/blob/676de99be0823e613e609057cbfc53618575a555/tweets.php#L3

Its been a while since I look at this/set it up, and I can see the comment above the code mentions setting it to your desired timezone here. But does this really need to be there? Or if it does, can't it just pull in the timezone thats been set in the grav config.

I've commented out this timezone set to fix my issue. Just concerned that if the plugin is updated it will wipe out the fix.

mdestafadilah commented 1 year ago

still work until now?