Add `HEX_TRUSTED_MIRROR_URL` configuration

hexpm / hex

Package manager for the Erlang ecosystem.

https://hex.pm

978 stars 187 forks source link

Add `HEX_TRUSTED_MIRROR_URL` configuration #956

Closed Benjamin-Philip closed 1 year ago

Benjamin-Philip commented 2 years ago

This commit:

Renames HEX_MIRROR to HEX_TRUSTED_MIRROR
Adds a new HEX_MIRROR which works like the old one but doesn't send the authorization header.

Closes #882.

ericmj commented 2 years ago

Hi @Benjamin-Philip! Are you still working on this? Otherwise I will grab it because we want to include this change in the next release.

Benjamin-Philip commented 2 years ago

Hi @Benjamin-Philip! Are you still working on this? Otherwise I will grab it because we want to include this change in the next release.

Hi @ericmj. I'm not currently working on this, as I've been busy for the past 1.5 months. When do you plan the next release? Perhaps I can finish it before the release if time permits.

ericmj commented 2 years ago

The next release will be out some time next week.

Also FYI, we are planning to pick up your work on web authentication in the coming weeks as well. Sorry for the delay on the that.

Benjamin-Philip commented 2 years ago

The next release will be out some time next week.

I'll not be able to finish this by then. Would you like to push to this PR or close this one and then open another?.

Also FYI, we are planning to pick up your work on web authentication in the coming weeks as well. Sorry for the delay on the that.

Great! I'll be honest with you - the delay is quite demotivating. While I do understand that the entire team is busy, old PRs with no signs of progress will only deter new and existing contributors. The delay has also created merge conflicts on both hexpm and hex which I will have to fix.

Also, a date will be very handy, I will be able to free up some time in my schedule and plan accordingly. Only if you can stick with the date though.

Benjamin-Philip commented 2 years ago

I've rebased to HEAD.

ericmj commented 2 years ago

Great! I'll be honest with you - the delay is quite demotivating. While I do understand that the entire team is busy, old PRs with no signs of progress will only deter new and existing contributors. The delay has also created merge conflicts on both hexpm and hex which I will have to fix.

That's understandable. We do our best to respond to issues and PRs but unfortunately the Hex maintainers have been busy with things outside of Hex lately and when we have been able to spend time on Hex the focus has been on fixing bugs, such as adding the new version solver, instead of new features.

Your contributions to Hex are very appreciated and I am sorry we have not been as responsive as you have wished.