search

hexpm / hex

Package manager for the Erlang ecosystem.
https://hex.pm
969 stars 184 forks source link

Convert HTTP module into hex_core adapter #990

Closed cgerling closed 1 year ago

cgerling commented 1 year ago

Part of https://github.com/hexpm/hex/issues/738

ericmj commented 1 year ago

Can you rebase against main so we can get CI to run? And let us know when it's ready for review again.

cgerling commented 1 year ago

I'm not entirely sure why the timeout was occurring but I found out that httpc only supports binaries as header values from OTP/24 and above, so I updated the code to encode header values as charlists to, it seemed to solve the timeout as well, I tested with all versions locally to be sure.

ericmj commented 1 year ago

Thank you @cgerling!