hexpm / specifications

Specifications for using and implementing Hex protocols
48 stars 26 forks source link

Renamed `yanked` to `retired` #11

Closed idyll closed 8 years ago

idyll commented 8 years ago

This PR renames yanked to retired to better represent that the package is not actually pulled.

Note that I changed the YankStatus to be RetirementStatus because it felt more natural to me than RetireStatus or RetiredStatus. Let me know if you want that changed.

ericmj commented 8 years ago

Looks good.

Btw, did you recompile the protocol buffer files or did you do search-replace on the produced .erlfiles?

idyll commented 8 years ago

:( find and replace... I didn't realize you compiled those.

ericmj commented 8 years ago

Okay, can you remove the erl changes and I will recompile them?

ericmj commented 8 years ago

Ping? :)

ericmj commented 8 years ago

I am going to merge this manually.