search

hexus / phaser-arcade-slopes

:triangular_ruler: A Phaser CE plugin that brings sloped tile collision handling to the Arcade Physics engine
MIT License
126 stars 16 forks source link

Typedef Fixes #15

Closed IkonOne closed 7 years ago

IkonOne commented 7 years ago

Fixes for the typedefs.

There are some interfaces in the definition that are there solely for type validation. Otherwise it would be a bit of a pain in Typescript to create these objects. (BodySlopes, BodySlopesSat and SatSolverOptions).

hexus commented 7 years ago

Nice, thank you. Looks good. Any chance this could be squashed into a single commit?

IkonOne commented 7 years ago

Yah I'll do that tomorrow morning and resubmit.

hexus commented 7 years ago

:ok_hand:

IkonOne commented 7 years ago

Closing to create the new PR.

IkonOne commented 7 years ago

@hexus If I didn't have all of the sloppy merging in that PR, would you not have been worried about flattening the PR?

(That's the last time make a non-merge commit to master)

hexus commented 7 years ago

Probably would've been okay, but I prefer just one commit per merge. Some projects I've seen like to see PRs sqashed to one commit per author where possible, and I kind of agree just for the sake of a concise history.

I forgot that Github lets you swash everything into one commit by itself though, so I could have done that instead to save you redoing things!