search

hexya-erp / hexya

Hexya business application development framework
http://hexya.io
Apache License 2.0
411 stars 125 forks source link

Support Postgresql SSLMode Parameter #16

Closed changwuf31 closed 6 years ago

codecov[bot] commented 6 years ago

Codecov Report

Merging #16 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #16   +/-   ##
======================================
  Coverage    82.3%   82.3%           
======================================
  Files          50      50           
  Lines        5571    5571           
======================================
  Hits         4585    4585           
  Misses        743     743           
  Partials      243     243

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3da497...b0e82f4. Read the comment docs.

npiganeau commented 6 years ago

Hi,

Thanks for your PR. I agree with your proposal, but it makes me realize that my connectToDB() function is not DB agnostic as it should. So I'll make a few updates on my side first.

npiganeau commented 6 years ago

It has been implemented in a database agnostic way. So I close.