search

hexylena / docker-rstudio-notebook

RStudio as a Galaxy Interactive Environment
MIT License
5 stars 17 forks source link

Fix container killing #26

Closed abretaud closed 5 years ago

abretaud commented 5 years ago

A fix for #25 It's not yet ready as now the container gets killed to early = monitor_traffic.sh thinks that user is gone when he is not I guess the < 3 test should be changed at https://github.com/erasche/docker-rstudio-notebook/blob/19.05/monitor_traffic.sh#L14, will look into it (I guess 3 was a valid value at some point!?)

abretaud commented 5 years ago

Should be ready now

hexylena commented 5 years ago

Do we not need to kill the init process which I guess is s6 now?

abretaud commented 5 years ago

I think it's done by https://github.com/erasche/docker-rstudio-notebook/pull/26/files#diff-cc54867128c9b83dd95f3a70ec135a1bR3? Took the code from https://github.com/just-containers/s6-overlay#writing-an-optional-finish-script

hexylena commented 5 years ago

Ok amazing!!! <3<3<3