hexylena / galaxyxml

XML Generation libraries for Galaxy Tool/ToolDeps XML
Apache License 2.0
6 stars 5 forks source link

order of exports to satisfy galaxy tool XML block standards and thus planemo linting? #27

Closed fubar2 closed 3 years ago

fubar2 commented 3 years ago

Planemo lint will fail current galaxyxml generated tools because the order of sections doesn't match the canonical version in lib/galaxy/tool_util/linters/xml_order.py. Fixing this first one manually and relinting leads to yet more. WARNING: Best practice violation [stdio] elements should come before [configfiles] Pity it wasn't alphabetical order like imported modules in python linters but this is what it currently is....

         """This module contains a linting functions for tool XML block order.

         For more information on the IUC standard for XML block order see -
         https://github.com/galaxy-iuc/standards.
         """
          https://github.com/galaxy-iuc/standards
          https://github.com/galaxy-iuc/standards/pull/7/files
         TAG_ORDER = [
             'description',
             'macros',
             'parallelism',
             'requirements',
             'code',
             'stdio',
             'version_command',
             'command',
             'environment_variables',
             'configfiles',
             'inputs',
             'outputs',
             'tests',
             'help',
             'citations', 
            ]
fubar2 commented 3 years ago

28 produces xml passing planemo lint

fubar2 commented 3 years ago

Thanks @hexylena !