hexylena / galaxyxml

XML Generation libraries for Galaxy Tool/ToolDeps XML
Apache License 2.0
6 stars 5 forks source link

Fixes to collections and repeats - now possible to test collections with elements and repeats with collections.... #35

Closed fubar2 closed 3 years ago

fubar2 commented 3 years ago

Apropos #34 and #32

Got the CL for outputcollections working. Children are new TestOCElements as mentioned in #34

Disambiguated test_repeat from repeat - not sure if that is needed but it seems clearer to me for them to have different names.

The following is a section of test XML now correctly parsed for elements in collections and collections in repeats - why anyone would want those I'm not sure but if they're ever needed, we are all set - at least nose thinks we are...

 <tests>
    <test>
      <param name="sequence" value="seq.fasta"/>
      <output file="file.gbk" name="genbank"/>
      <output_collection name="pdf_out">
         <element name="apdf" file="apdf" ftype="pdf"/>
      </output_collection>
      <repeat name="testrepeat">
          <param name="repeatchild" value="foo"/>
      </repeat>
      <repeat name="output_repeat">
          <output file="outputchild" name="bar"/>
      </repeat>
      <repeat name="collection_repeat">
          <output_collection name="collectionchild">
              <element name="elementary" file="efile" ftype="txt"/>
          </output_collection>
      </repeat>
    </test>
 </tests>
fubar2 commented 3 years ago

Disambiguated test_repeat from repeat - not sure if that is needed but it seems clearer to me for them to have different names. was a foolish move. Fixed back to what it was - it has to be <repeat> !

fubar2 commented 3 years ago

@hexylena: is there anything else I need to fix before this is merged? or was that second approval yesterday meant to be a merge?