hey-api / openapi-ts

🚀 The OpenAPI to TypeScript codegen. Generate clients, SDKs, validators, and more. Support: @mrlubos
https://heyapi.dev
Other
1.39k stars 107 forks source link

fix: handle nullable enums in experimental parser #1248

Closed mrlubos closed 2 weeks ago

mrlubos commented 2 weeks ago

Closes https://github.com/hey-api/openapi-ts/issues/1246

stackblitz[bot] commented 2 weeks ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 61cd848262b20580fb185d023c28aa54754bf19c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------- | ----- | | @hey-api/openapi-ts | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 2:12am
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 40.32258% with 37 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@de21dfd). Learn more about missing BASE report. Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ages/openapi-ts/src/openApi/3.0.x/parser/schema.ts 0.00% 30 Missing :warning:
...ages/openapi-ts/src/openApi/3.1.x/parser/schema.ts 77.77% 6 Missing :warning:
packages/openapi-ts/src/openApi/index.ts 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1248 +/- ## ======================================= Coverage ? 67.69% ======================================= Files ? 132 Lines ? 19491 Branches ? 1749 ======================================= Hits ? 13195 Misses ? 6292 Partials ? 4 ``` | [Flag](https://app.codecov.io/gh/hey-api/openapi-ts/pull/1248/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hey-api) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/hey-api/openapi-ts/pull/1248/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hey-api) | `67.69% <40.32%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hey-api#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.