Closed Nick-Lucas closed 3 months ago
Run & review this pull request in StackBlitz Codeflow.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
hey-api-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 18, 2024 8:06am |
Latest commit: 1017acee80630d84a08bd8f0087c8fb0de270f1a
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Attention: Patch coverage is 3.19149%
with 91 lines
in your changes missing coverage. Please review.
Project coverage is 70.89%. Comparing base (
4a2fb1f
) to head (1017ace
).
Files | Patch % | Lines |
---|---|---|
packages/openapi-ts/src/compiler/transform.ts | 2.70% | 72 Missing :warning: |
packages/openapi-ts/src/utils/write/types.ts | 0.00% | 19 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mrlubos this one is ready, company codebase is now compiling and seems to be working! So just the one oversight that I honestly should have caught before
Just fixing 1 issue. Models get transforms, but response model aliasing didn't account for responses being arrays of models. We now have a transform for arrays too