hey-api / openapi-ts

✨ Turn your OpenAPI specification into a beautiful TypeScript client
https://heyapi.vercel.app
Other
1.07k stars 88 forks source link

Fix discovered issues with types+transform output #690

Closed Nick-Lucas closed 3 months ago

Nick-Lucas commented 3 months ago

Just fixing 1 issue. Models get transforms, but response model aliasing didn't account for responses being arrays of models. We now have a transform for arrays too

stackblitz[bot] commented 3 months ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 8:06am
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 1017acee80630d84a08bd8f0087c8fb0de270f1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------- | ----- | | @hey-api/openapi-ts | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 3.19149% with 91 lines in your changes missing coverage. Please review.

Project coverage is 70.89%. Comparing base (4a2fb1f) to head (1017ace).

Files Patch % Lines
packages/openapi-ts/src/compiler/transform.ts 2.70% 72 Missing :warning:
packages/openapi-ts/src/utils/write/types.ts 0.00% 19 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #690 +/- ## ========================================== - Coverage 71.63% 70.89% -0.75% ========================================== Files 76 76 Lines 7897 7984 +87 Branches 696 696 ========================================== + Hits 5657 5660 +3 - Misses 2237 2321 +84 Partials 3 3 ``` | [Flag](https://app.codecov.io/gh/hey-api/openapi-ts/pull/690/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hey-api) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/hey-api/openapi-ts/pull/690/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hey-api) | `70.89% <3.19%> (-0.75%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hey-api#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Nick-Lucas commented 3 months ago

@mrlubos this one is ready, company codebase is now compiling and seems to be working! So just the one oversight that I honestly should have caught before