heyajohnny / afvalinfo

Provides Home Assistant sensors for multiple Dutch waste collectors. The idea is to add more cities and features in the future.
GNU General Public License v3.0
102 stars 22 forks source link

please add montferland #161

Closed jerwij closed 3 years ago

jerwij commented 3 years ago

Dear johnny,

Is it possible to add gemeente Montferland to the code?

Best regards, Jeroen

heyajohnny commented 3 years ago

Ehhh... It's already there an it should work...

jerwij commented 3 years ago

I See. My bad. I was only looking in the locations folder and did't read the readme.

heyajohnny commented 3 years ago

No problem and Thnx for the tip :)

jerwij commented 3 years ago

Is the trashapi yours? pbd is missing in the JSON: [ { "date": "2021-01-12T00:00:00", "name": "Restafval", "daysTillDate": 4 }, { "date": "2021-01-16T00:00:00", "name": "Papier", "daysTillDate": 8 }, { "date": "2021-01-18T00:00:00", "name": "Gft", "daysTillDate": 10 } ]

heyajohnny commented 3 years ago

Yes it's mine :) It makes updating the code so much easier. They've changed the naming from "Plastic, Metaal en Drankenkartons" to "PMD".I've just added the "PMD" to match it with pbd.

Please let me know if it works.

jerwij commented 3 years ago

I see it now in the api JSON respone! Thnx!

jerwij commented 3 years ago

I still get an errormessage(PMD is now showing with an date, so that one is fixed):

Logger: homeassistant.components.rest.sensor Source: components/rest/sensor.py:256 Integration: rest (documentation, issues) First occurred: 16:59:25 (51 occurrences) Last logged: 17:25:27

REST result could not be parsed as JSON

heyajohnny commented 3 years ago

Strange. Works just fine with this address: location: montferland postcode: 7037AW streetnumber: 63

jerwij commented 3 years ago

Last days I get an "404 Not found" status of the service. Possibly someting went wrong by adding new destricts?

jerwij commented 3 years ago

And fixed 👍