search

heyajohnny / cryptoinfo

Provides Home Assistant sensors for all cryptocurrencies supported by CoinGecko
GNU General Public License v3.0
49 stars 14 forks source link

Add simple price fetching with config and fallback for main fetch #36

Closed TheHolyRoger closed 1 year ago

TheHolyRoger commented 1 year ago

You might not like this one but it's working well for my needs given the API endpoint is still disabled :)

Adds a use_simple_price config option to use one of the basic price endpoints, and also uses that as a fallback for the main fetch if it fails

heyajohnny commented 1 year ago

Sorry, I'm going to cancel this request. It could also happen that the basic price is offline. So you can go on forever with fallback requests

TheHolyRoger commented 1 year ago

No worries I'll just use it on my own fork. For my purposes I only need the simple price feed and not all the stats.

The fallback is only tried once btw not forever.

TheHolyRoger commented 1 year ago

@heyajohnny I decided to diverge on my own fork https://github.com/TheHolyRoger/hass-cryptoinfo

Feel free to pinch anything if you like it, I added a Dominance sensor :)

heyajohnny commented 1 year ago

@TheHolyRoger That's cool! At this moment I have some other projects that take my time, but feel free to make it as you desire. I always had the idea to integrate multiple API's , but never had the time. Now you only have CoinGecko. Maybe you could add something like CoinMarketCap or others. Maybe even a DefiLlama or ??? . Just an idea...

TheHolyRoger commented 1 year ago

@heyajohnny just released a major refactor, added some basic stats from cryptoid too :)

TheHolyRoger commented 1 year ago

@heyajohnny if you're interested, have a look at my dashboard now with my latest cryptoinfo release :)

https://community.home-assistant.io/t/bitcoin-cryptocurrency-dashboards/563576

heyajohnny commented 1 year ago

That looks really awesome! Keep up the good work 👍

TheHolyRoger commented 1 year ago

@heyajohnny thanks man. I want to get mine onto HACS. I've basically rewritten the whole thing now and moved to async with a reload service too.

Have you got any interest in working together or should I rename my integration to something else and put it on HACS?

heyajohnny commented 1 year ago

As for now I'm not interested in working together, because I have other priorities. Please rename your integration and put it on HACS. What I can do is make a reference in my README page to your repo. Something like 'For more advanced features see ....' Please let me know...

TheHolyRoger commented 1 year ago

@heyajohnny thanks! I've renamed it in this repo https://github.com/TheHolyRoger/hass-cryptoinfo

Going through the motions now of adding to brands, hacs

Can I use your same logo?

heyajohnny commented 1 year ago

Yeah, you could do whatever you want. It's all free for use.