heyajohnny / cryptoinfo

Provides Home Assistant sensors for all cryptocurrencies supported by CoinGecko
GNU General Public License v3.0
49 stars 14 forks source link

can't rename sensors #49

Open h8hr1pzdo3rmiqv5 opened 5 days ago

h8hr1pzdo3rmiqv5 commented 5 days ago

Tried the new version 1.0.0 today.

It worked at first, but i renamed the sensors (_sensor.cryptoinfo_name_bitcoin_usd1 to _sensor.cryptoinfo_bitcoinusd, for example) and the sensor aren't updated anymore. Renamed one back to its original name, and now it's working again.

Having a mandatory identifier is annoying, but that's me. My use case of CryptoInfo is to get rates only (hence the multiplier 1) to set alerts. I initially set up an identifier named "rate", simply. However, i lost the history from versions 0.x.x. Not a big deal.

Having the multiplier in the sensor name is weird, no? As the multiplier is a reflection of one's wallet, it is subject to change. It's not in my use case, but someone having a dashboard of their savings would not find it handy to update every reference to the sensor each time their wallet is changed.

Suggested fix: either let the entry follow the renamings of its sensors, or remove the multiplier from the sensor name.

Thank you for your work. It's a useful integration.

heyajohnny commented 5 days ago

Having the multiplier in the sensor name is weird, no?

Yeah you have a point there... In the version I just released (v1.0.1), the multiplier is removed from the identifier. The problem with renaming the sensor will probably take some more time. I hope to have some time this week. I'll keep you updated.