search

heybereket / oasis

The chat and forums platform for communities
https://beta.oasis.sh
MIT License
241 stars 54 forks source link

Bug: cancelling login leads to 404 #490

Open 4rgc opened 3 years ago

4rgc commented 3 years ago

Issue description

If you press cancel on the GitHub OAuth login page, it will redirect you to https://beta.oasis.sh/login and show a 404 screen.

Steps to reproduce the issue

  1. Be logged out.
  2. Press Login on the home page
  3. Press Cancel on the GitHub's OAuth login page.

What's the expected result?

Get redirected to the home page.

What's the actual result?

Get redirected to the login page, and see the 404 error.

Additional details / screenshot

screenshot

Simplyalex99 commented 3 years ago

Hello, I was wondering if there was any update on this issue( if it was resolved)? I believe this is happening because during the Oauth process, if something is unsuccessful the default URL is the 404 page which is correct. So what we can do is add some event listener , or cancel token or something to know when the cancel button is clicked to change the redirected URL to homepage and not 404.

mchccn commented 3 years ago

currently we're moving away from the monorepo so maybe it will be fixed in api or web