search

heyitsbench / mod-worgoblin

Module for AzerothCore that adds Worgen and Goblin as playable races.
GNU Affero General Public License v3.0
14 stars 17 forks source link

error #134 0x85100086 #2

Closed NiganNi closed 2 years ago

NiganNi commented 2 years ago

Hello friend, everything turned out to be created, even to play as goblins. But I ran into the following problems: 1) goblins can't speak (but I think I'll figure it out myself) 2) after I created the worgen, when I try to enter the world at the end of the download, it gives an error # 134 0x85100086 2022-01-06_12-01-37

NiganNi commented 2 years ago

Hello friend, I'm still getting an error trying to enter the world as a worgen.

Log errore: `---------------------------------------- Memory Dump

Stack: 1024 bytes starting at (ESP = 038EED4C)

` The log file shows that the error is most likely in spells\errorcube.m2 Any ideas how to fix this?

heyitsbench commented 2 years ago

Well given the error number, my guess is a permissions error

NiganNi commented 2 years ago

Hello friend, we still managed to enter the world, but the worgen looks like a crossed orc with a worgen. A very scary and incomprehensible creature. When crafted, the worgen looks amazing: 2022-01-26_13-30-26 But in the game, he looks more like a terrible orc mutilated by sewage: 2022-01-26_13-30-46 2022-01-26_13-31-02 My guess is that this is due to the replacement of the worgen with a fel orc. But I don't know how to fix it in DBC. Any ideas how to fix this?

heyitsbench commented 2 years ago

Are you replacing the DBC files on your server with the ones provided in the repo?

NiganNi commented 2 years ago

Oh sure. Can you show me what your worgen model looks like in game?

heyitsbench commented 2 years ago

image

NiganNi commented 2 years ago

Good afternoon friend, could you send me (listfile) from patch-A. I can't change the content. The problem is clearly in the patch, and specifically something with the ChrRaces.dbc file. If I apply your patch I will get the error I described. Also, if I delete ChrRaces.dbc from the server side, I get workOrc. But if I create a patch from these files https://github.com/mthsena/trinitycore_scripts/tree/master/scripts/CustomRaces/MPQ, then I won't get new races. Therefore, I want to edit my patch-A, but it is without listfile.txt 2022-01-30_17-18-21

something is clearly wrong with your patch as it requires a lot of memory: 2022-01-30_17-22-56

I did everything according to the description and not only, but I can not implement the worgen.

heyitsbench commented 2 years ago

I'm sorry, but I don't see how it's possible that the issue is with the patch. The patch I upload to this repo and the one I use for my own production server are different, I'll give you that, but I just tested the exact same patch file on this repo and it works perfectly fine for me. The only thing I could attribute your issue to is that your client is not in fact clean as you say it is.

NiganNi commented 2 years ago

I have already tried 3 different clips, the result is the same. I tried it from different computers with different RAM, but the error repeats. It's as if some process is loaded into infinity and when it selects all the memory, it gives this error, but this is my guess. Give a link to your client and I'll try it, but I think it's unlikely that the client is the case.

heyitsbench commented 2 years ago

Would you be able to upload a screenshot of the directory you're moving the patch file to in your wow client?

NiganNi commented 2 years ago

Hello friend here is the screenshot: 111

heyitsbench commented 2 years ago

Does it happen if you're only logged in as a worgen/goblin? Does it crash with other races as well? Does it crash if you stay at the login screen?

Also: https://www.chromiecraft.com/downloads/ This is the client I suggest you try instead. My users have reported issues with the HD patch as well, so keep that in mind.

NiganNi commented 2 years ago

1) Does this happen if you're only logged in as a worgen/goblin? I only get the error when replacing the ChrRace.dbc file in my server's dbc folder. This only happens to the worgen race! If not replaced, we get an orc-worgen. 2) Does this happen to other races as well? No. 3) Will it crash if you stay at the login screen? No.

4) Also: https://www.chromiecraft.com/downloads/ This is the client I suggest you try. My users have also reported issues with the HD fix, so keep that in mind. I tried to download this client, the situation is the same.

Friend, I've actually tried everything I could and I'm disappointed. Probably it remains only to compare the versions of the core. AzerothCore rev. 38bf355bf479+ 2020-12-16 10:03:09 +0000 (master branch) (Win64, Release) (worldserver-daemon) I also have a hunch that this is due to the replacement of fel orcs, since the racial number of worgen is 22, and here 12 as fel orcs. This assumption is due to the fact that goblins work amazingly.

NiganNi commented 2 years ago

Even the cards were pulled from a new client. The result is the same... Here is the error text: 2022-02-10 20.02.36 Error.txt

NiganNi commented 2 years ago

Here is what I found: in file line 12 columns 5 and 6 correspond to male and female models (according to:https://trinitycore.atlassian.net/wiki/spaces/tc/pages/2129966/ChrRaces) You have 40029 and 40030 there, respectively. Now I checked this cataclysm file, in line 22 there are worgens 29422 and 29423, I think the problem is related to incorrect display of the model.

Nelnamara commented 2 years ago

Same issue compile with module went off without a hitch. Goblins seem to be loading fine.
Worgen crash client on load fron toon screen. ac error worgen

Nelnamara commented 2 years ago

I am trying again with a clean compile, Have been using ChromieCraft with no HD mods. My error only happens with Worgens...

Nelnamara commented 2 years ago

I was able to cleanly compile and login to game this time, Same issue as NiganNi.

I have replaced dbc files as directed applieed sql Applied the worgen.patch - But I did have to try multiple commands to get it to go. Can you tell me any git apply switches I should be using? I wonder if this is because my SharedDefines file was improperly patched? I am showing my client data folder structure with Patch A installed.

If possible can you share your patched SharedDefines file?

Thanks! hoping we can troubleshoot this down. I am excited to roll this into my guilds fun server

I made a Worgen male and it looked like NiganNi's result. when attempting to make a female the client crashed Screen Shot 2022-02-26 at 12 12 04 PM Screen Shot 2022-02-26 at 12 11 29 PM Screen Shot 2022-02-26 at 12 22 35 PM WoWScrnShot_022622_121059 WoWScrnShot_022622_121107 .

Nelnamara commented 2 years ago

I went over my SharedDefines by hand and it looks as you specified in your patch. Attaching here. I am going to re copy the dbc files and try again here shortly. Checking permissions etc...

Kind of scratching my head, Compile gives zero errors!

#ifndef ACORE_SHAREDDEFINES_H
#define ACORE_SHAREDDEFINES_H

#include "Define.h"
#include "DetourNavMesh.h"
#include <cassert>

float const GROUND_HEIGHT_TOLERANCE = 0.05f; // Extra tolerance to z position to check if it is in air or on ground.
constexpr float Z_OFFSET_FIND_HEIGHT = 2.0f;

enum SpellEffIndex
{
    EFFECT_0 = 0,
    EFFECT_1 = 1,
    EFFECT_2 = 2,
};

// used in script definitions
#define EFFECT_FIRST_FOUND 254
#define EFFECT_ALL 255

// loot modes for creatures and gameobjects, bitmask!
enum LootModes
{
    LOOT_MODE_DEFAULT                  = 0x01,
    LOOT_MODE_HARD_MODE_1              = 0x02,
    LOOT_MODE_HARD_MODE_2              = 0x04,
    LOOT_MODE_HARD_MODE_3              = 0x08,
    LOOT_MODE_HARD_MODE_4              = 0x10,
    LOOT_MODE_JUNK_FISH                = 0x8000
};

enum Expansions
{
    EXPANSION_CLASSIC                  = 0,
    EXPANSION_THE_BURNING_CRUSADE      = 1,
    EXPANSION_WRATH_OF_THE_LICH_KING   = 2,
    MAX_EXPANSIONS                     = 3
};

enum Gender
{
    GENDER_MALE                        = 0,
    GENDER_FEMALE                      = 1,
    GENDER_NONE                        = 2
};

// Race value is index in ChrRaces.dbc
// EnumUtils: DESCRIBE THIS
enum Races
{
    RACE_NONE               = 0,  // SKIP
    RACE_HUMAN              = 1,  // TITLE Human
    RACE_ORC                = 2,  // TITLE Orc
    RACE_DWARF              = 3,  // TITLE Dwarf
    RACE_NIGHTELF           = 4,  // TITLE Night Elf
    RACE_UNDEAD_PLAYER      = 5,  // TITLE Undead
    RACE_TAUREN             = 6,  // TITLE Tauren
    RACE_GNOME              = 7,  // TITLE Gnome
    RACE_TROLL              = 8,  // TITLE Troll
    RACE_GOBLIN             = 9,  // TITLE Goblin
    RACE_BLOODELF           = 10, // TITLE Blood Elf
    RACE_DRAENEI            = 11, // TITLE Draenei
    RACE_WORGEN             = 12 //, TITLE Worgen
    //RACE_FEL_ORC        = 12,
    //RACE_NAGA           = 13,
    //RACE_BROKEN         = 14,
    //RACE_SKELETON       = 15,
    //RACE_VRYKUL         = 16,
    //RACE_TUSKARR        = 17,
    //RACE_FOREST_TROLL   = 18,
    //RACE_TAUNKA         = 19,
    //RACE_NORTHREND_SKELETON = 20,
    //RACE_ICE_TROLL      = 21
};

// max+1 for player race
#define MAX_RACES         13

#define RACEMASK_ALL_PLAYABLE \
    ((1<<(RACE_HUMAN-1))   |(1<<(RACE_ORC-1))          |(1<<(RACE_DWARF-1))   | \
    (1<<(RACE_NIGHTELF-1))|(1<<(RACE_UNDEAD_PLAYER-1))|(1<<(RACE_TAUREN-1))  | \
    (1<<(RACE_GNOME-1))   |(1<<(RACE_TROLL-1))        |(1<<(RACE_GOBLIN-1))| \
    (1<<(RACE_BLOODELF-1))|(1<<(RACE_DRAENEI-1))      |(1<<(RACE_WORGEN-1)))

#define RACEMASK_ALLIANCE \
    ((1<<(RACE_HUMAN-1)) | (1<<(RACE_DWARF-1))   | (1<<(RACE_NIGHTELF-1)) | \
    (1<<(RACE_GNOME-1)) | (1<<(RACE_DRAENEI-1)) | (1<<(RACE_WORGEN-1)))

#define RACEMASK_HORDE RACEMASK_ALL_PLAYABLE & ~RACEMASK_ALLIANCE`
Nelnamara commented 2 years ago

I noticed an error while running the server after compile and install. One of the entries made by the sql change is not being picked up for anything.
SharedDefines Patched

DBC files have been copied to /azerothcore/build/data/dbc Compiled without error

Patch A in Client Data Folder.

The goofy Orcs have no skills spells or racials etc beyond the standard general stuff.

Screen Shot 2022-02-26 at 1 42 06 PM Screen Shot 2022-02-26 at 1 39 36 PM

heyitsbench commented 2 years ago

@NiganNi @porkserver Would either of you be willing to give this patched exe a chance? I'm worried that this exe I've been using has an extra change for memory allocation on top of MD5 signature removal.

(Link removed due to not being relevant)

heyitsbench commented 2 years ago

Applied the worgen.patch - But I did have to try multiple commands to get it to go. Can you tell me any git apply switches I should be using? I wonder if this is because my SharedDefines file was improperly patched?

To be 100% honest, I only included the patch file as that was what was included with the original TC custom race script I started this from. I have only ever done it by hand and don't know what sort of script or compiling switch would apply it on compile. I did however tell the Github workflow file to apply the patch on line 27 without causing errors on the build, so those switches might be the ones to look at.

heyitsbench commented 2 years ago

Okay, there is absolutely an issue with the DBC files posted on the repo, and I'm very sorry especially to you, @NiganNi, for dragging my feet on testing the issue and fixing it. Currently hunting through the DBCs to find which one(s) are being problematic.

heyitsbench commented 2 years ago

Okay, should be fixed with https://github.com/benjymansy123/mod-worgoblin/commit/f02545ee56a56b207cf2947ad4125e4c99950aa8

heyitsbench commented 2 years ago

Tested and working with every race/gender combination, displaying as should be expected and not crashing at all.

  1. goblins can't speak (but I think I'll figure it out myself)

Also apparently didn't include voice effects either, so those should be working now too

Nelnamara commented 2 years ago

Confirmed working with new package!

Any pointers on customizing things like starting spells and abilities? I am new to customizing things in my server so I am wondering how much editing I can do in the database and what needs dbc editing etc...

heyitsbench commented 2 years ago

Confirmed working with new package!

Great to hear it!

Any pointers on customizing things like starting spells and abilities? I am new to customizing things in my server so I am wondering how much editing I can do in the database and what needs dbc editing etc...

In my experience, a lot of spells and abilities granted upon character creation seem to be (At least at the server level I think) DBC controlled.

heyitsbench commented 2 years ago

Going to wait on a couple other folks to chime in with testing results before closing this.

NiganNi commented 2 years ago

Confirmed, now it works great. Thank you so much benjymansy123! Since this issue is resolved, I'm closing the topic. With the addition of racial spells, I'll create a separate question a bit later.