search

heyitsbench / mod-worgoblin

Module for AzerothCore that adds Worgen and Goblin as playable races.
GNU Affero General Public License v3.0
12 stars 17 forks source link

Reorganize skills/spells upon creation. #28

Open heyitsbench opened 2 years ago

heyitsbench commented 2 years ago

Currently the racial spells/skills that are being assigned are sorta hackfixed to be given on creation in a way dissimilar to stock races. That's gotta get fixed.

heyitsbench commented 2 years ago

A bunch of skills still aren't being given when they should, such as 2h axe proficiency for worgen warriors. I believe this is due to DBC discrepancies, as I believe this skill is being adjusted in the DB query. Intention is to retroport/adjust the gear that worgen/goblins start with in Cata and adjust skills loosely based on Cata due to the fact that proficiencies with armors/weapons was changed quite a bit.

heyitsbench commented 2 years ago

Okay, ported all the gear in 77955b2e58bfd03debb768ff2436d0118c90db92. https://github.com/benjymansy123/mod-worgoblin/blob/master/sql/world/item_template.sql needs to get fixed quickly, because the armor/one of the stat value columns are swapped I guess I don't know what happened there, but it's required for worgen/goblins to spawn with gear. Very cool. Once the SQL is fixed, then fixing skills is next priority.

heyitsbench commented 2 years ago

Fixed in d597c4029ce16d79fd7eeac2542c6499958d2414 and moved to worgoblin.sql in 5d791ea157f25a90eede69c9889960bcfcd68c7e. Now to fix skills. As of right now, goblin warriors are missing 2h mace, rogues are missing 1h mace, and worgen rogues are missing 1h axe skill.

heyitsbench commented 2 years ago

Reorganized some skills with 2094f4ac10966ec754e5af4e16075c007250fc14, e1a7c1502806be1da6f370c5f5ce2425e2df9796, and 12ef986023d3dee51647cfccf42b7e7a11995e17. Going to go through every class combo with worgen/goblins and figure out what I want to be given or learnable and set it up accordingly (and also test every one, which sounds excruciatingly tedious.) As of right now, no race/class combo is being given a piece of gear that they can't wear, so that's some progress at least.

Alyst3r commented 1 year ago

A bunch of skills still aren't being given when they should, such as 2h axe proficiency for worgen warriors.

I believe this may actually be caused by races not being defined in SharedDefines.h but I did not really take my time to recompile after adding them. But what makes me believe this, is a bunch of errors from worldserver.exe errors