search

heyitsbench / mod-worgoblin

Module for AzerothCore that adds Worgen and Goblin as playable races.
GNU Affero General Public License v3.0
15 stars 17 forks source link

Convert patch into module #5

Open Helias opened 2 years ago

Helias commented 2 years ago

I don't know if I already told you, but I had the same idea about this, I would like to create a module like mod-race-goblin or mod-race-worgen.

We should convert the patch into a module (may changing the core a bit to be compatible with the module).

heyitsbench commented 2 years ago

We should convert the patch into a module (may changing the core a bit to be compatible with the module).

https://github.com/azerothcore/azerothcore-wotlk/issues/7648

To my knowledge there aren't any hooks currently available in AC to be utilized for this yet. If one gets added or if an existing one can serve the same purpose, I'd be more than happy to convert this into a module properly rather than require users to patch their core to use it.

Unfortunately I have no idea how to add a hook myself, nor have I really investigated it much.

Helias commented 2 years ago

We could change the define lists into hashmap as I did here https://github.com/azerothcore/azerothcore-wotlk/pull/1444 and allow to change those hashmap values also from modules. We could even add some hooks to add them but it's a bit complicated I think