Itinerary title functionality

heyitsmass / BayView

The next generation reservation tracking and notification system

https://bayview.dev

MIT License

1 stars 2 forks source link

Itinerary title functionality #90

Closed cpilande closed 11 months ago

cpilande commented 11 months ago

Description

This PR implements the itinerary title dialog that opens when the location button is clicked on the Itinerary Title Card in order to select which park the user will go to.

Motivation and Context

This PR is necessary to further broaden the functionality of the Itinerary Title Card.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] - My code follows the code style of this project.
[ ] - My change requires a change to the documentation.
[ ] - I have updated the documentation accordingly.
[ ] - I have read the CONTRIBUTING document.
[ ] - I have added tests to cover my changes.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
bay-view	✅ Ready (Inspect)	Visit Preview	Nov 27, 2023 0:42am

cpilande commented 11 months ago

Modals should implement a ReactPortal to properly expose outside of the parent DOM

https://react.dev/reference/react-dom/createPortal

Headless UI library says it implements it for us: “Because of these accessibility concerns, Headless UI's Dialog component actually uses a Portal under-the-hood. This way we can provide features like unobstructed event handling and making the rest of your application inert. So, when using our Dialog, there's no need to use a Portal yourself! We've already taken care of it.” https://headlessui.com/react/dialog#

heyitsmass commented 11 months ago

Modals should implement a ReactPortal to properly expose outside of the parent DOM https://react.dev/reference/react-dom/createPortal

Headless UI library says it implements it for us: “Because of these accessibility concerns, Headless UI's Dialog component actually uses a Portal under-the-hood. This way we can provide features like unobstructed event handling and making the rest of your application inert. So, when using our Dialog, there's no need to use a Portal yourself! We've already taken care of it.” https://headlessui.com/react/dialog#