Section titles in exercise detail view should not say "in # days" since they were done in the past

heyjaywilson / peakfit

Strength exercise iOS app written in Swift

Apache License 2.0

16 stars 10 forks source link

Section titles in exercise detail view should not say "in # days" since they were done in the past #36

Closed heyjaywilson closed 1 month ago

heyjaywilson commented 2 months ago

The section titles in ExerciseDetailView should either say "# days ago" or the date the exercise reps were performed. They currently say "in # days" which implies they are in the future, and this is incorrect.

Here is thie figma doc showing what the ExerciseDetailView() is supposed to look like but with the default trailing padding.

Drag0ndust commented 1 month ago

I can have a look at this bug if it is available

heyjaywilson commented 1 month ago

Definitely available. I just assigned you another issue though and trying to keep it at 1 issue per person.

heyjaywilson commented 1 month ago

@Drag0ndust since your PRs have gone through, do you want to try this one still?

Drag0ndust commented 1 month ago

I would leave it for someone else. If it is not taken by mid-October, I can have a look.

SpacyRicochet commented 1 month ago

Sounds like a nice one to start with. Can I take it then?

heyjaywilson commented 1 month ago

Sure can @SpacyRicochet!

SpacyRicochet commented 1 month ago

Okay, I thought that this would be an easy fix, but apparently iOS is very, very drunk. Look at the Saturday's a bit further in 😅