search

heyjuvi / avizo

A neat notification daemon
GNU General Public License v3.0
450 stars 23 forks source link

Scripts use /bin/sh but depends on non-posix extensions #48

Closed hen6003 closed 1 month ago

hen6003 commented 2 years ago

This causes lightctl to fail on voidlinux, as line 116 causes the script to crash. Replacing /bin/sh with /bin/bash fixes this

jirutka commented 2 years ago

https://github.com/misterdanb/avizo/blob/67af5fd55279c25546d79cebdb4cb73440093082/lightctl#L116

added in #44. Moreover, it’s unnecessary, this can be easily written as light=${light%%.*}. And that is_float condition is also unnecessary.

heyjuvi commented 1 year ago

@jirutka Have you tested the suggested change? I'm not a bash/sh expert, so I rely on some suggestions. Do you want to make a pull request? (I can also just integrate the change if it's really that simple)