heylinda / heylinda-app

The open source and free meditation app alternative for everyone. Built with React Native and Expo.
https://heylinda.netlify.app
GNU Affero General Public License v3.0
672 stars 164 forks source link

fixed display of hour plus long tracks #153

Open thehalvo opened 2 years ago

thehalvo commented 2 years ago

Description

If a meditation track was greater than 59:59 it would not display the hours. It would just leave them out.

Ticket Link

N/A

How has this been tested?

Tested the play screen using these devices:

iPhone 13 - Simulator

Screenshots

Screen Shot 2022-06-24 at 12 12 59 AM

Checklist

netlify[bot] commented 2 years ago

Deploy Preview for webheylinda ready!

Name Link
Latest commit 2bce04a0d095f6c79a79cc9c7414b472b86ced3c
Latest deploy log https://app.netlify.com/sites/webheylinda/deploys/64a304931b46c200089aa2f1
Deploy Preview https://deploy-preview-153--webheylinda.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

watadarkstar commented 2 years ago

Awesome @thehalvo!

Thanks for fixing this issue. Can you add some additional tests for this case here so we don't ever regress: https://github.com/heylinda/heylinda-app/blob/main/hooks/__tests__/useMsToTime.tests.ts

thehalvo commented 2 years ago

@watadarkstar sure done.