search

heylinda / heylinda-app

The open source and free meditation app alternative for everyone. Built with React Native and Expo.
https://heylinda.netlify.app
GNU Affero General Public License v3.0
672 stars 164 forks source link

[Bug] Calendar background color does not update when Dark mode is toggled #20

Closed AliNisarAhmed closed 2 years ago

AliNisarAhmed commented 3 years ago

Before reporting:

Steps to reproduce:

  1. Start with Dark or Light mode in Android settings
  2. Note Calendar background color
  3. Switch to Light/Dark mode
  4. Calendar background color remains the same
  5. Restarting the app fixes the issue

Expected behaviour:

Should reflect the current theme like the rest of the app.

Actual behaviour:

Calendar background color is from the old theme.

Smartphone (please complete the following information):

Screenshots/Recording: Settings - before Calendar - before Settings - after App - after

AliNisarAhmed commented 3 years ago

@watadarkstar Were you able to reproduce this issue? Before attempting to resolve this, I want to rule out it was not just my simulator doing this (Cannot check on my physical device as Dark mode is not detected on it at all).

watadarkstar commented 3 years ago

@AliNisarAhmed Yup I reproduced it. It must be something to do with the calendar library not re-rendering when the props change or something

AliNisarAhmed commented 3 years ago

I cannot reproduce this on my device and emulator (no idea why). Clearing myself from assignees so that someone else can take a look at this.