Added Notifications with repeating Schedules Solves #55

[SalikSayyed]

Description

Build

• notificationHandler
• notificationSetter
• WeekDaySelector Used Expo local notifications.

fix #55

Ticket Link

Closes #55

How has this been tested?

Pixel 2 API 29 - Simulator

Screenshots

Checklist

• [x] Added a "Closes [issue number]" in the ticket link section
• [x] You have not changed whitespace unnecessarily (it makes diffs hard to read)
• [x] You have commented your code, particularly in hard-to-understand areas
• [x] You have performed a self-review of your own code
• [x] UI changes: include screenshots of all affected screens

[watadarkstar]

Nice work @SalikSayyed! I will review the code soon. In terms of the UI, what about placing the weekday / time part inside a modal that pops up instead of placing it inside the list? You can use react-native-paper's Dialog component for the modal and put it in its own component like NotificationDialog :) This will make things easier to move around in the future.

https://callstack.github.io/react-native-paper/dialog.html

[SalikSayyed]

I made few changes and added dialog box this time.

[SalikSayyed]

@watadarkstar plz review this. I have put the notification permission on homescreen. I think now its complete.

[watadarkstar]

The toast library is giving me this issue, do I have to run pod install? In any case, let's stick with the libraries we already have installed and use https://callstack.github.io/react-native-paper/snackbar.html.

[watadarkstar]

Nice work @SalikSayyed, I left a few more comments and then this should be good!

[SalikSayyed]

The toast library is giving me this issue, do I have to run pod install? In any case, let's stick with the libraries we already have installed and use https://callstack.github.io/react-native-paper/snackbar.html.

Changed to SnackBar. no new package needed

[SalikSayyed]

Hello, @watadarkstar will u please review this ?

[watadarkstar]

@SalikSayyed Sure reviewing it now :) Thank you for reminding me!

The UI is a bit odd. The pick time and notify buttons don't feel right. What I recommend:

• Get rid of the "Pick time" button and instead always display the time. Set the default time to 8:00 AM. Its an extra step to have to click "Pick time" to bring up the time selector.
• Move the "Cancel" button to the left side.
• Move the "Notify" button to where "Cancel" is right now and use the same styles as the "Cancel" button
• For the days, can we add some margin between each day so they don't look so squashed together?

This would make the UI look more clean 🥇

[watadarkstar]

When I click "Pick time" the UI changes to this (which has a lot of white space and looks wonky):

We don't need the "At 19:14" here as we already show the time below. Let's just always show the time selector and default it to 8 AM:

[watadarkstar]

@SalikSayyed Aside from the UI, the code looks good and clean! I look forward to seeing the updated UI when you have a chance to tweak it :)

[watadarkstar]

@SalikSayyed Please also resolve the conflicts with master :)

[watadarkstar]

Hey @SalikSayyed can you give me write access to your fork so I can modify stuff if needed?

[SalikSayyed]

@watadarkstar check this I updated with few addition, decreased the size entirely and Auto Cancel of dialog when set, no cancel wehn not set since it is dismissable I dont think cancel is needed. As for TimePicker updated it for IOS, for android when clicking on the Timing displayed opens UI to put timing. Please verify for IOS as well..

[SalikSayyed]

Hey @SalikSayyed can you give me write access to your fork so I can modify stuff if needed?

Yes,That would be great. I added u as collaborator sent invite. Or should I do something else for write access?? @watadarkstar

[watadarkstar]

@SalikSayyed Its looking better! Nice work. I will jump in and tweak stuff and then get this merged in once I tweak the UI a bit :)