search

heynemann / motorengine

Motorengine is a port of MongoEngine for Tornado.
http://motorengine.readthedocs.org
204 stars 64 forks source link

Allow passing simple strings as ids for get #61

Closed cyrilrbt closed 10 years ago

cyrilrbt commented 10 years ago

I found it annoying to have to import ObjectId all the time, and don't really see a risk in converting strings to ObjectIds on the fly.

Edit: Had to cancel previous pull request, had forgotten unicode.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling ed052d7a9e11c078a9dacf7c1a3d174c58b87e5f on cyrilrbt:master into b36bdda8c5b581af96ea26004b2e32c48d5e282e on heynemann:master.

heynemann commented 10 years ago

Can you provide a test case for this pull request?

Thank you for your contribution!

heynemann commented 10 years ago

Your code also does not work in python 3.3 and pypy (look at the travis CI build for more info).

heynemann commented 10 years ago

Released under 0.8.9. Thanks for your contribution.