heysion / wave-protocol

Automatically exported from code.google.com/p/wave-protocol
0 stars 0 forks source link

Empty search query causes shiny #229

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Login to WIAB
2. Clear the search box.
3. Hit enter.

What is the expected output? What do you see instead?
Expected: Not sure what should be the expected result, in GWave all waves are 
displayed. Surely no exception should be thrown.
Actual: Shiny with the following error:
One or more exceptions caught, see full set in UmbrellaException#getCauses
  Unknown.cG (Unknown source:0)
  Unknown.pG (Unknown source:0)
  Unknown.HW (Unknown source:0)
  Unknown.dW (Unknown source:0)
  Unknown.hW (Unknown source:0)
  Unknown.RV (Unknown source:0)
  Unknown.eHb (Unknown source:0)
Caused by: query cannot be empty
  Unknown.cG (Unknown source:0)
  Unknown.eTb (Unknown source:0)
  Unknown.qD (Unknown source:0)
  Unknown.ylc (Unknown source:0)
  Unknown.Tlc (Unknown source:0)
  Unknown.moc (Unknown source:0)
  Unknown.enc (Unknown source:0)

I suggest that empty query should be replaced with some default query, i.e. 
"in:inbox".

Original issue reported on code.google.com by vega113 on 25 Feb 2011 at 6:30

GoogleCodeExporter commented 8 years ago
please review patch at: URL: http://codereview.waveprotocol.org/550001

Original comment by vega113 on 25 Feb 2011 at 6:32

GoogleCodeExporter commented 8 years ago
fixed by 6b1dc65306

Original comment by vega113 on 26 Feb 2011 at 10:13