search

heysupratim / material-daterange-picker

A material Date Range Picker based on wdullaers MaterialDateTimePicker
Apache License 2.0
1.33k stars 266 forks source link

DialogFragment api is deprecated #105

Open tomscholz opened 5 years ago

tomscholz commented 5 years ago

Hi, I'm running into this issue where when I'm using this library, that Android Studio gives me an error, saying that the DialogFragment API is deprecated. If I've understood the Android documentation correctly, we could solve this problem by switching to the support library or to androidX.

What do you think?

Cheers, Tom

heysupratim commented 5 years ago

Thanks for pointing this out. I would love to get some help on fixing this if anyone is interesting in putting out a PR for this.

If not, it will be the first thing I take up in my next lib update stretch

fullmoon6661 commented 5 years ago

I stumbled on the same issue, any updates on androidx?

ibrahimbroachwala commented 4 years ago

+1 with the issue. Any updates?

OneXeor commented 4 years ago

+1

OneXeor commented 4 years ago

I solved it with the deprecated fragment manager from Activity activity?.fragmentManager?.beginTransaction()?.add(picker, "")?.commit()

carrymaster commented 4 years ago

+1

rollin-s commented 4 years ago

+1

If anyone have found a solution, I'd love to have it.

androidovshchik commented 4 years ago

+1