heyxyz / hey

Hey is a decentralized and permissionless social media app built with Lens Protocol 🌿
https://hey.xyz
GNU Affero General Public License v3.0
23.29k stars 1.54k forks source link

Add Support for Images on DMs (XMTP) #2791

Closed petermdenton closed 1 year ago

petermdenton commented 1 year ago

Summary

Overview

Adding images to the DM experience would bring more engagement to users messaging across Lenster. Images would make the messaging experience on par with other messaging platform user experiences and open the door to more and more engaging attachments across Lens.

User Experience

As you can see in the video below, a user can:

Watch the video below: https://user-images.githubusercontent.com/483/227057859-b5dd6059-cdd5-4224-81ac-22d97029afe9.mov

In the video above, we (XMTP) have used the newly introduced Attachment and RemoteAttachment content types which you can read more about here: https://xmtp.org/blog/attachments-and-remote-attachments.

Type of change

PR for Feature

The PR is available in this branch: https://github.com/lensterxyz/lenster/pull/2149

bigint commented 1 year ago

This is a great idea 🚀

My only concern is uploading images as base64 to xmtp might not be a good idea for lenster, as it takes too long to load, and me miss some features like distributing images to CDN, transcoding etc.

We also don't want to show loading while loading and image, if we use CDN it will be near instant on further loads.

I suggest to use traditional ipfs uploader where we already used in new posts/comments component.