heyxyz / hey

Hey is a decentralized and permissionless social media app built with Lens Protocol 🌿
https://hey.xyz
GNU Affero General Public License v3.0
23.29k stars 1.54k forks source link

Add progressive loading of images from blur to bright #3067

Closed bigint closed 9 months ago

bigint commented 1 year ago

null

ENG-12

bigint commented 1 year ago

/bounty $50

Nirali-Ahir commented 1 year ago

/attempt #3067

Options
theonlyjunaid commented 1 year ago

/attempt #3067 I can take this up I did this before, please assign me

Options
algora-pbc[bot] commented 1 year ago

Note: The user @Nirali-Ahir is already attempting to complete issue #3067 and claim the bounty. If you attempt to complete the same issue, there is a chance that @Nirali-Ahir will complete the issue first, and be awarded the bounty. We recommend discussing with @Nirali-Ahir and potentially collaborating on the same solution versus creating an alternate solution.

Nirali-Ahir commented 1 year ago

Hey @bigint @foolo, I'm halfway through. I wanted to ask do we have low-resolution thumbnail images available from ImageKit ? Or should I use a static placeholder image while the main image is loading?

theonlyjunaid commented 1 year ago

@Nirali-Ahir i can help in getting imagekit low resolution image can we do it together. @bigint @foolo i just want to confirm that are you using imagekit by default or not because some images are not on imagekit

Nirali-Ahir commented 1 year ago

@Nirali-Ahir i can help in getting imagekit low resolution image can we do it together. @bigint @foolo i just want to confirm that are you using imagekit by default or not because some images are not on imagekit

mine almost done just nned to asign prop

foolo commented 1 year ago

@theonlyjunaid @Nirali-Ahir I don't know if the super-low-res images are readily aviable on ImageKit, but yes, we should use Imakekit. So maybe it need to be configured to generate mini thumbnails.

in the Linear issue, @bigint wrote the following:

we can use imagekit to reduce image size to 5px x 5px to load the initial image and load the big image next to that

theonlyjunaid commented 1 year ago

@Nirali-Ahir i can help in getting imagekit low resolution image can we do it together. @bigint @foolo i just want to confirm that are you using imagekit by default or not because some images are not on imagekit

mine almost done just nned to asign prop

You can refer https://docs.imagekit.io/features/image-optimization/quality-optimization for getting the image of custom quality without changing in dimensions of image

theonlyjunaid commented 1 year ago

@theonlyjunaid @Nirali-Ahir I don't know if the super-low-res images are readily aviable on ImageKit, but yes, we should use Imakekit. So maybe it need to be configured to generate mini thumbnails.

in the Linear issue, @bigint wrote the following:

we can use imagekit to reduce image size to 5px x 5px to load the initial image and load the big image next to that

imagekit provides options for custom quality that we can use according to our need in which quality can range from 1-100. image with quality 1 has almost 10 times smaller size compared to the image with quality 100

Nirali-Ahir commented 1 year ago

https://github.com/heyxyz/hey/assets/144760374/4736e944-8ec1-48b8-ad64-3826f822e134

MohakBajaj commented 11 months ago

/attempt #3067

Options
algora-pbc[bot] commented 11 months ago

Note: The user @Nirali-Ahir is already attempting to complete issue #3067 and claim the bounty. If you attempt to complete the same issue, there is a chance that @Nirali-Ahir will complete the issue first, and be awarded the bounty. We recommend discussing with @Nirali-Ahir and potentially collaborating on the same solution versus creating an alternate solution.

abdoollaahh commented 11 months ago

/attempt #3067

Options
algora-pbc[bot] commented 11 months ago

Note: The user @Nirali-Ahir is already attempting to complete issue #3067 and claim the bounty. If you attempt to complete the same issue, there is a chance that @Nirali-Ahir will complete the issue first, and be awarded the bounty. We recommend discussing with @Nirali-Ahir and potentially collaborating on the same solution versus creating an alternate solution.

AayushMohan commented 11 months ago

/attempt #3067

Options
algora-pbc[bot] commented 11 months ago

Note: The user @Nirali-Ahir is already attempting to complete issue #3067 and claim the bounty. If you attempt to complete the same issue, there is a chance that @Nirali-Ahir will complete the issue first, and be awarded the bounty. We recommend discussing with @Nirali-Ahir and potentially collaborating on the same solution versus creating an alternate solution.

Kamran1819G commented 11 months ago

/attempt #3067

Options
feliciien commented 10 months ago

can i work on this one ?

hamzaahmadaslam commented 10 months ago

Hey can i start this one?

bigint commented 10 months ago

@hamzaahmadaslam go through the above convos!

Rutik7066 commented 10 months ago

hey @bigint I have experienced with blur to bright image loading. May get assigned this one or should start working on it directly?

bigint commented 9 months ago

No longer needed!

github-actions[bot] commented 9 months ago

This issue has been locked since it has been closed for more than 10 days.

If you found a concrete bug or regression related to it, please open a new bug report.