search

heyyy / espa

Automatically exported from code.google.com/p/espa
0 stars 0 forks source link

Code review request #95

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name:espa-2.2.3-release

Purpose of code changes on this branch:
Implemented FTP transfers instead of SCP

When reviewing my code changes, please focus on:
cdr_ecv.py.  distribute_product, ftp_to_online_cache, ftp_from_online_cache, 
staging scenes in __main__

Original issue reported on code.google.com by davehil...@gmail.com on 10 Dec 2013 at 3:46

GoogleCodeExporter commented 9 years ago 
Also, cdr_ecv_mapper.py and cdr_ecv_cron.py have changed.

Original comment by davehil...@gmail.com on 10 Dec 2013 at 3:48

GoogleCodeExporter commented 9 years ago

Original comment by davehil...@gmail.com on 10 Dec 2013 at 3:49

GoogleCodeExporter commented 9 years ago 
I think the majority of that code changes look good, just a few comments.

cdr_ecv.py:
  Line 1582 - MODIFY should be MODIFIED
  Line 1584 - Should remove this commented "def" of the called ftp routine
  Lines 1595-1600 - Should remove this commented code as well, since the scp code was removed from all the other locations.

General:
  I don't think we should be passing around the password in plain text in the order file.  Also one other related thing to note, is that when cdr_ecv.py gets called from the command line the user names and passwords will be visible to anyone on the system who knows where to look.
  On a side note, I would argue that if some malicious person from the outside is on the system it is already too late.

Original comment by rd.alt.5...@gmail.com on 10 Dec 2013 at 5:37

GoogleCodeExporter commented 9 years ago 
Totally agree that if someone is in a position to even see that stuff then
we have much bigger problems.  I will create a ticket to at least obfuscate
the passwords if not outright encrypt them with a symmetric key.

Original comment by davehil...@gmail.com on 10 Dec 2013 at 6:19

GoogleCodeExporter commented 9 years ago 
Cleaned up the cdr_ecv.py comment remarks.

Original comment by davehil...@gmail.com on 10 Dec 2013 at 6:21

GoogleCodeExporter commented 9 years ago 
Entered a ticket to encrypt the passwords within the job file.

Original comment by davehil...@gmail.com on 10 Dec 2013 at 6:23

GoogleCodeExporter commented 9 years ago

Original comment by davehil...@gmail.com on 10 Dec 2013 at 6:28

GoogleCodeExporter commented 9 years ago

Original comment by davehil...@gmail.com on 23 Apr 2014 at 5:02