Open heyzec opened 1 year ago
The feature follows the functionality specified in the UG, which is that it is sorted by the order specified in the command, thus it is not a functionality bug.
The team does not think that the user would expect sorting to be deterministic. The team also cannot think of a reasonable use case where the same sort command will be repeated twice.
Team chose [response.Rejected
]
Reason for disagreement: I concede that this is not a functionality bug, rather, a feature flaw.
I think that for pretty much all the software we use, sorting is deterministic. e.g. sorting issues on GitHub.
Less to do with use case of sorting twice. Rather, one rare possibility of confusion occurs when a user sorts the listings, and remembers that he/she is interested in a specific index. After running other commands, if the user sorts again, the index may change, leading to confusion.
Team chose [type.FeatureFlaw
]
Originally [type.FunctionalityBug
]
Reason for disagreement: [replace this with your explanation]
Steps:
addprop -n Clementi Flat -p 50000 -a 311 Clementi Ave 2, #02-25 -d Ready to be bought -o John -ph 98765432 -c 3-Room; Near School
. This creates a new property with the same price of $50000 as Residential College 4.sortprops -p DESC
sortprops -p DESC
. This causes index 2 and 3 to jump.This behaviour might not be ideal since user expects sorting to be deterministic.