heyzec / pe

0 stars 0 forks source link

Error message can be improved when command does not follow format #6

Open heyzec opened 1 year ago

heyzec commented 1 year ago

When command does not follow format, the error message will not hint to the user that a prefix is missing, in this example.

image.png

soc-pe-bot commented 1 year ago

Team's Response

  1. If we were to implement this, parsing would be very difficult.
  2. 5 College Avenue East could also be a valid address. Then the error message would be correct.

    Items for the Tester to Verify

    :question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I don't think the validity of the arguments has anything to do with whether the error message is correct. The meesage is incorrect here because the at least one field to edit must be provided. Format of commands should be checked before validity.


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: My reason is same as above.