Project Feedback!

[codepathreview]

@heziel : The requirement User can view more tweets as they scroll with infinite pagination doesnt seem to be implemented. The code for pagination is also commented out - https://github.com/heziel/TripleTweet/blob/master/app/src/main/java/com/codepath/apps/tripletweet/activity/TimelineActivity.java#L161. Pls fix this asap and update the status here.

[heziel]

Hi, thank you for letting me know, i guess i forgot to update i know it's an easy fix but let's just say it's undone Hezi.

On Mon, Oct 31, 2016 at 11:54 PM, CodePath Reviewers < notifications@github.com> wrote:

@heziel https://github.com/heziel : The requirement User can view more tweets as they scroll with infinite pagination doesnt seem to be implemented. The code for pagination is also commented out - https://github.com/heziel/TripleTweet/blob/master/app/ src/main/java/com/codepath/apps/tripletweet/activity/ TimelineActivity.java#L161. Pls fix this asap and update the status here.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/heziel/TripleTweet/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AFeDTnie1XNjl34jCKPbrVkVN8xXyDa7ks5q5uIbgaJpZM4Kl0dg .

[nesquena]

Okay, thanks, please reply again here and re-submit once updated and ready for review

[heziel]

Updted, thank you and good night.

On Tue, Nov 1, 2016 at 12:23 AM, Nathan Esquenazi notifications@github.com wrote:

Okay, thanks, please again here and re-submit once updated and ready for review

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/heziel/TripleTweet/issues/1#issuecomment-257504351, or mute the thread https://github.com/notifications/unsubscribe-auth/AFeDThOwMBY0wGecZOfuGFEGHtXRHfjpks5q5ukOgaJpZM4Kl0dg .

[codepathreview]

:+1: nice work. A few notes after checking out the code:

• Nice to see you successfully used OAuth login. OAuth is widely used and it's important to understand OAuth v1 and v2 properly.
• Good to see you were able to format the timestamp cleanly.
• Nice to see you used the SwipeRefreshLayout for easy timeline refreshes.
• Nice touch with the character count being displayed while the user composes a tweet.
• Good to see you used DialogFragment. Fragment is an important component and its use is good practice.
• Consider using GSON to conveniently serialize and deserialize API responses into objects.
• Consider adding local persistence of tweets by using DBFlow in the Tweet and User. See the persistence guide and this other guide for more details.

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.