Remove pyclbr and use inspect instead for module introspection

hfaran / Tornado-JSON

A simple JSON API framework based on Tornado

http://tornado-json.readthedocs.org/

MIT License

273 stars 60 forks source link

Remove pyclbr and use inspect instead for module introspection #97

Closed hfaran closed 7 years ago

hfaran commented 7 years ago

This is being replaced due to pyclbr being broken in Python 3.5 for our use case. Inspect works just as well for what we need.

Resolves #96

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 96.024% when pulling 41963676cf60ef9f2934181c474ace4c659cceca on hfaran/remove_pyclbr into cb55a6d81423c5330fa4ad2e8a5c947905f77f60 on master.

djbright commented 7 years ago

@hfaran, finally got the chance to test and this indeed resolved #96 for us. Thanks again!

hfaran commented 7 years ago

Great, thanks for confirming. PR is merged, and a new version with this fix (and some other additions that hadn't been rolled into a release yet) are now in v1.3.0. It has also been pushed to PyPI.